🛡️ Sentinel: [MEDIUM] Fix sensitive error detail disclosure in login_required - #16
Conversation
Prevent leaking raw exception details (str(e)) in 401 responses when authentication verification fails. Co-authored-by: Pmaster-dev <293764797+Pmaster-dev@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
🚨 Severity: MEDIUM
💡 Vulnerability: The
login_requireddecorator inauth/utils.pyincluded raw exception messages (str(e)) in 401 Unauthorized responses.🎯 Impact: Unauthenticated callers could trigger authentication errors to expose sensitive internal details such as database trace messages, token parsing internal details, or backend exception details.
🔧 Fix: Removed
'details': str(e)from the unauthorized 401 response payload inauth/utils.py.✅ Verification: Created unit tests in
tests/test_auth_utils.pythat trigger authentication exceptions and assert that only{'error': 'Unauthorized'}is returned without internal exception details. Passed test suite and linting.PR created automatically by Jules for task 18225427508450441577 started by @Pmaster-dev